add SYMBOL_VISIBILITY cache variable to match scons interface. #1579
Conversation
CMakeLists.txt
Outdated
| # https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html | ||
| # To match the scons options we need to change the text to match the -fvisibility flag | ||
| # it is probably worth another PR which changes both to use the flag options | ||
| if( ${SYMBOL_VISIBILITY} STREQUAL "auto" OR ${SYMBOL_VISIBILITY} STREQUAL "visible" ) |
There was a problem hiding this comment.
I think we need to decide if we are going to standardize on having a GODOT_ prefix for all our options (and so GODOT_SYMBOL_VISIBILITY), or not.
What do most other cmake projects do?
There was a problem hiding this comment.
SFML also prefixes options with SFML_ (unless they're standardized, e.g. CMAKE_BUILD_TYPE).
Some macros also have it: sfml_set_option.
There was a problem hiding this comment.
yes prefixing variables is the norm in cmake projects, would you like me to go back and change it, and then submit a PR bringing other options into line?
There was a problem hiding this comment.
Execllent, to be clear we will be prefixing everything with GODOT_ yeah ? not GODOT_CPP_?
There was a problem hiding this comment.
Yeah, let's do GODOT_ - we're already mostly using that one (with a couple exceptions), and there really isn't a world where you have Godot and godot-cpp in the same codebase, so I don't think we'll conflict
|
Ah, sorry, I didn't notice this when I approved: you need to squash this down to a single commit before I can merge it. This is part of Godot's development workflow: https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#modifying-a-pull-request |
enetheru
force-pushed
the
visibility-hidden
branch
from
4c19673 to
02bdc66
Compare
|
Apologies, commits have been squashed and I'll remember it for next time. |
|
Thanks! |
dsnopek
added
enhancement
|
Cherry-picked for 4.2 in PR #1631 |
|
Cherry-picked for 4.3 in PR #1632 |
Bring the 'cmake -LH' output inline with the scons output.
I dont know what the policy on adding notes in comments are.
I can ammend the commit to remove them if they are unwanted.