-
-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace legacy hooks with pre-commit
Python tool
#1504
Conversation
0c213bc
to
e0d363a
Compare
Thanks, this looks really great! Seems to work perfectly in my testing. Skimming the changes, they seem to match all the equivalents in the Godot repo. And all the code style fixes seem good to me too. |
Cherry-picked for 4.2 in PR #1527 |
Cherry-picked for 4.1 in PR #1529 |
The main README.md does not appear to have been updated yet. It still mentions: There is a short section about the new I suppose linking to this would be an acceptable solution? |
Yes, I think that would be fine! Feel free to make a PR to update the README :-) UPDATE: Oh, nevermind, you already did! #1686 |
Overhauls the hook system to utilize the main repo's
pre-commit
hook logic. Migrated relevant files and settings over as needed, as well as applying any detected changes. In particular, this changes the python formatting system fromblack
toruff
& ensures all the tools used in the checks are now easily accessible viapyproject.toml
. Themisc/hooks
folder was removed entirely, with all relevant logic being handled inmisc/scripts
or.pre-commit-config.yaml
.