Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update free_property_list callback to take count #1450

Merged
merged 1 commit into from
May 8, 2024

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Apr 26, 2024

Adds support for changes in PR godotengine/godot#91179

Note: This doesn't change how we handle properties using the count, it sticks with the same old approach.

Keeping this as a draft until that PR is merged

@dsnopek dsnopek added the enhancement This is an enhancement on the current functionality label Apr 26, 2024
@dsnopek dsnopek added this to the 4.x milestone Apr 26, 2024
@dsnopek dsnopek requested a review from a team as a code owner April 26, 2024 18:41
@dsnopek dsnopek marked this pull request as draft April 26, 2024 18:41
@AThousandShips AThousandShips added the waiting for Godot This issue needs a Godot Engine improvement to be solved label Apr 26, 2024
@dsnopek dsnopek force-pushed the free-property-list-count branch from 348c718 to 563ee30 Compare April 26, 2024 18:55
@dsnopek dsnopek force-pushed the free-property-list-count branch from 563ee30 to 8cc78cf Compare April 30, 2024 13:48
@dsnopek dsnopek marked this pull request as ready for review April 30, 2024 13:49
@dsnopek
Copy link
Collaborator Author

dsnopek commented Apr 30, 2024

Since PR godotengine/godot#91179 is now merged, I've taken this out of draft.

And I've also taken this opportunity to remove the comment about the const on GDExtensionClassFreePropertyList being incorrect, since we resolved that it's not over on that PR.

@dsnopek dsnopek removed the waiting for Godot This issue needs a Godot Engine improvement to be solved label Apr 30, 2024
@dsnopek dsnopek merged commit e3f3cb5 into godotengine:master May 8, 2024
12 checks passed
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants