fix export action name #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason0214
force-pushed
the
fix_export_action_name
branch
5 times, most recently
from
4c0bbd3 to
7fd78b1
Compare
sdfgeoff
reviewed
Aug 6, 2018
| # blender would automatically add a '.001' for a name collision | ||
| # hacky solution by adding a space to make name different, | ||
| # space is ignored in godot animation name | ||
| baked_action.name = ' ' + base_action.name |
There was a problem hiding this comment.
Doesn't this mean that you'll get a bunch of identicly named actions in godot's animation window. I think that would be quite a pain to try and use (particuarly if you're trying to trigger those actions from gscript).
There was a problem hiding this comment.
No, exported actions has the same number of actions you have in blender. The baked action is always new created because I found if baking into the original action, blender would not set the original action back when addon finish exporting. So this new created action is actually a temporal one and would be removed after it get evaluated and exported
Jason0214
force-pushed
the
fix_export_action_name
branch
4 times, most recently
from
f9767f6 to
acec5af
Compare
Jason0214
force-pushed
the
fix_export_action_name
branch
from
acec5af to
b0b2cbc
Compare
Ben1138
pushed a commit
to Ben1138/godot-blender-exporter
that referenced
this pull request
Oct 2, 2024
fix export action name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix some bugs brought by #63
animation_data, constraint will be baked to an action