Add seamless polygon border line #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added seemless closed line function.
Added seemless closed line function.
Added seamless closed line function.
Calinou
reviewed
Jun 26, 2022
Calinou
reviewed
Jun 26, 2022
Calinou
approved these changes
Jun 26, 2022
Visual comparisonClick to view at full size.
|
Calinou
pushed a commit
to godot-extended-libraries/godot-antialiased-line2d-demo
that referenced
this pull request
Jun 26, 2022
Calinou
added
bug
|
Thank you! It feels good to give a little back... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit eliminates the visible defect in the polygon border line where it formerly closed with a rounded end.
It does this by computing a bridge point midway between the start and end points and adding this point to the beginning and end of the PoolVector2Array defining the line. The butt ends of the line then always meet orthogonally and thus invisibly.