Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental optimizations #219

Merged
merged 5 commits into from
Sep 14, 2021
Merged

Incremental optimizations #219

merged 5 commits into from
Sep 14, 2021

Conversation

tarkatronic
Copy link
Contributor

This includes just a couple of small, incremental tweaks that should offer a little bit of performance gain.

  • Using __slots__ for the Issue class should help a lot during initial deep scans of large repositories. This should improve both memory consumption and, to some lesser degree, the speed of instantiating the Issue class.
  • Doing some quick initial profiling, it appears that generating the diff between hashes is one of the most run lines in the code, and also one of the more expensive. So now we don't even generate it until after we know the file should be scanned.

Both of these are pretty minor, but should help some, especially in more extreme cases.

Copy link
Contributor

@rbailey-godaddy rbailey-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sushantmimani sushantmimani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦅

@tarkatronic tarkatronic merged commit 8469e18 into main Sep 14, 2021
@tarkatronic tarkatronic deleted the incremental-optimizations branch September 14, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants