Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tartufo fails to run with click v8.1.0 #339

Closed
tarkatronic opened this issue Mar 28, 2022 · 0 comments · Fixed by #340
Closed

tartufo fails to run with click v8.1.0 #339

tarkatronic opened this issue Mar 28, 2022 · 0 comments · Fixed by #340
Assignees
@tarkatronic
Labels
bug Something isn't working

Comments

@tarkatronic
Copy link
Contributor

🐛 Bug Report

Today, the click library released v8.1.0 (https://github.com/pallets/click/releases/tag/8.1.0). According to the release notes:

This is a feature release, which includes new features and removes previously deprecated features.

Unfortunately, we relied on at least one of these "previously deprecated features", causing tartufo to break when used alongside this new version.

Full changelog can be seen here: https://click.palletsprojects.com/en/8.1.x/changes/#version-8-1-0

To Reproduce

  • Install tartufo alongside v8.1.0 of click
  • Run any tartufo scan
@tarkatronic tarkatronic added the bug Something isn't working label Mar 28, 2022
@tarkatronic tarkatronic self-assigned this Mar 28, 2022
@tarkatronic tarkatronic mentioned this issue Mar 28, 2022
Merged
sushantmimani pushed a commit that referenced this issue Mar 28, 2022
@tarkatronic
Fixes #339 - Fix compatibility issues with latest click (#340)
06c2499 
* Fix click version incompatibilities

* Upgrade to latest black for click compatibility

* Fix a pylint error on naming

* Version bump for quick bugfix release

* More strict version pinning for click on Python 3.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tarkatronic tarkatronic

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #339 - Fix compatibility issues with latest click godaddy/tartufo
1 participant
@tarkatronic