fix(splitio-api-binding): filter out archived splits (#10)

godaddy · Dec 16, 2019 · b48af5a · b48af5a
1 parent 26e4576
commit b48af5a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/splitio-api-binding.js b/lib/splitio-api-binding.js
@@ -85,7 +85,7 @@ class SplitioApiBinding {
     const { allChanges, since } = await this.getAllChanges({ path })
     allChanges.forEach(change => {
       change.splits.forEach(split => {
-        splitChanges.push(split)
+        if (split.status !== 'ARCHIVED') { splitChanges.push(split) }
       })
     })
     return { splitChanges, since }

diff --git a/lib/splitio-api-binding.test.js b/lib/splitio-api-binding.test.js
@@ -140,14 +140,15 @@ describe('lib.splitio-api-binding.SplitioApiBinding', () => {
   describe('getSplitChanges', () => {
     const mockSplits0 = { status: 'bar' }
     const mockSplits1 = { status: 'baz' }
-    it('returns all splits and the since value', async () => {
+    const mockSplits2 = { status: 'ARCHIVED' }
+    it('returns all active splits and the since value', async () => {
       const splitioApiBinding = new SplitioApiBinding({ splitioApiKey: 'foo' })
       const requestStub = sinon.stub()
       splitioApiBinding.getAllChanges = requestStub
       requestStub.onCall(0).resolves({
         allChanges: [
           { splits: [mockSplits0], till: 0 },
-          { splits: [mockSplits1], till: 1 }
+          { splits: [mockSplits1, mockSplits2], till: 1 }
         ],
         since: 1
       })