Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix order of quiz prev and next question buttons #2864

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

kamzil
Copy link

@kamzil kamzil commented Jan 27, 2025

Description

Fix order of quiz prev/next buttons. After this fix, "next" button will properly be placed after the "prev" button.

How has this been tested?

By installing the plugin and opening a quiz

Types of changes

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@kamzil kamzil requested a review from ideadude as a code owner January 27, 2025 22:27
@brianhogg
Copy link
Contributor

brianhogg commented Jan 28, 2025

@kamzil Thanks for the PR! We wouldn't merge this in as-is for everyone, as many sites expect it to be in the current order. We have a CSS-based solution for swapping the buttons and we're investigating an option to allow the order to be swapped if someone wants to.

@kamzil
Copy link
Author

kamzil commented Jan 29, 2025

Thanks for the link, but for some reason the suggested CSS doesn't have an effect on our site with Sky Pilot theme, at least on Firefox on Mac or Edge on Windows. I hope we can find another solution soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Awaiting Review
Development

Successfully merging this pull request may close these issues.

2 participants