Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard facilities or reference external dependencies used in the examples #7

Closed
thenikso opened this issue Oct 14, 2014 · 1 comment · Fixed by #9
Closed

Use standard facilities or reference external dependencies used in the examples #7

thenikso opened this issue Oct 14, 2014 · 1 comment · Fixed by #9

Comments

@thenikso
Copy link

Just adopted this guide on a new project and digging it. Here are some things that slowed me in the adoption (with opinion on how to change them):

  • Not being used to $stateProvider (from ui-route I believe) I'd expect it to be replaced by $routeProvider or a reference to be provided
  • The use of UnderscoreJS should be avoided as it implies a dependency or a reference be provided
  • A ES6 module transpiler to IE5 should be suggested (or a list of production ready one provided)
@feelepxyz
Copy link
Contributor

@thenikso good points! We'll add a section on our tooling setup and external deps later today.

maxmurdoch added a commit that referenced this issue Oct 14, 2014
maxmurdoch added a commit that referenced this issue Oct 14, 2014
maxmurdoch added a commit that referenced this issue Oct 14, 2014
maxmurdoch added a commit that referenced this issue Oct 14, 2014
jackfranklin added a commit that referenced this issue Oct 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants