Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

cleaned up per request logging #504

Merged
merged 3 commits into from
Jul 11, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions default_context.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ func (d *DefaultContext) Render(status int, rr render.Renderer) error {
data["params"] = pp
data["flash"] = d.Flash().data
data["session"] = d.Session()
data["request"] = d.Request()
bb := &bytes.Buffer{}

err := rr.Render(bb, data)
Expand Down
20 changes: 11 additions & 9 deletions middleware/param_logger.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,19 @@ import (
// ParameterLogger logs form and parameter values to the logger
func ParameterLogger(next buffalo.Handler) buffalo.Handler {
return func(c buffalo.Context) error {
req := c.Request()
if req.Method != "GET" {
b, err := json.Marshal(req.Form)
defer func() {
req := c.Request()
if req.Method != "GET" {
b, err := json.Marshal(req.Form)
if err == nil {
c.LogField("form", string(b))
}
}
b, err := json.Marshal(c.Params())
if err == nil {
c.LogField("form", string(b))
c.LogField("params", string(b))
}
}
b, err := json.Marshal(c.Params())
if err == nil {
c.LogField("params", string(b))
}
}()
return next(c)
}
}
16 changes: 7 additions & 9 deletions request_logger.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,20 +27,18 @@ func RequestLoggerFunc(h Handler) Handler {
}
rid := irid.(string) + "-" + randx.String(10)
c.Set("request_id", rid)
c.LogField("request_id", rid)

start := time.Now()
c.LogFields(logrus.Fields{
"request_id": rid,
"method": c.Request().Method,
"path": c.Request().URL.String(),
})
ct := c.Request().Header.Get("Content-Type")
if ct != "" {
c.LogField("content_type", ct)
}
defer func() {
ws := c.Response().(*Response)
ct := c.Request().Header.Get("Content-Type")
if ct != "" {
c.LogField("content_type", ct)
}
c.LogFields(logrus.Fields{
"method": c.Request().Method,
"path": c.Request().URL.String(),
"duration": time.Since(start),
"size": ws.Size,
"human_size": humanize.Bytes(uint64(ws.Size)),
Expand Down