Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Moving action generator tests to use filetest #439

Merged
merged 8 commits into from
May 18, 2017

Conversation

paganotoni
Copy link
Member

@markbates according to #407 this one moves actions generator tests to use filetest instead of go tests.

@paganotoni paganotoni requested a review from markbates May 16, 2017 01:25
@paganotoni paganotoni changed the base branch from master to development May 16, 2017 01:25
@markbates
Copy link
Member

I'm getting the following error:

--- FAIL: TestAppendRoute (0.00s)
        Error Trace:    helpers_test.go:82
	Error:      	Not equal: 
	            	expected: "package actions\n\nimport (\n\t\"os\"\n\n\t\"github.com/gobuffalo/buffalo\"\n\t\"github.com/gobuffalo/buffalo/examples/json-crud/models\"\n\t\"github.com/gobuffalo/buffalo/middleware\"\n\t\"github.com/markbates/going/defaults\"\n)\n\nvar ENV = defaults.String(os.Getenv(\"GO_ENV\"), \"development\")\nvar app *buffalo.App\nfunc App() *buffalo.App {\n\tif app == nil {\n\t\tapp = buffalo.Automatic(buffalo.Options{\n\t\t\tEnv: ENV,\n\t\t})\n\n\t\tapp.Use(middleware.SetContentType(\"application/json\"))\n\t\tapp.Use(middleware.PopTransaction(models.DB))\n\n\t\tapp.Use(findUserMW)\n\t\tapp.GET(\"/users\", UsersList)\n\t\tapp.GET(\"/new/route\", UserCoolHandler)\n\t}\n\n\treturn app\n}"

@paganotoni
Copy link
Member Author

yes, sorry @markbates, fixing that with my latest commit. i also sent this PR to filetest so it can now do contains with a count.

@markbates
Copy link
Member

@apaganobeleno the tests are so much faster now!! thank you!!

@paganotoni
Copy link
Member Author

👍 still need to work on other test cases, i'll send another PR later after this one merges.

@markbates markbates merged commit 60dfdb6 into development May 18, 2017
@markbates markbates deleted the moving-action-tests-to-filetest branch May 18, 2017 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants