This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Add Golint and fix all issues #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbates
reviewed
Jan 28, 2017
| @@ -4,11 +4,11 @@ import ( | |||
| "os" | |||
|
|
|||
| "github.com/gobuffalo/buffalo/examples/hello-world/actions" | |||
| . "github.com/markbates/grift/grift" | |||
| mbgrift "github.com/markbates/grift/grift" | |||
| "github.com/olekukonko/tablewriter" | |||
There was a problem hiding this comment.
Why are we using a special name here?
There was a problem hiding this comment.
Whoops, just pushed a commit to fix it.
when I first started this PR . . . I misread something and thought there was a namespace collision. But there's not.
|
Other than the one question I have, this looks good. |
|
@markbates Corrected |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go Report Card reported 26 linting issues with Buffalo:
https://goreportcard.com/report/github.com/gobuffalo/buffalo
I went through and corrected all of them, plus added linting to the Travis test.
@markbates As discussed, I just made standard golint pass. You may want to keep grifts imports as a top-level rather than namespaced. (I personally found this confusing because of how many different type of "Context" types get passed around)
So - if you want me to do some modifications to allow for dot imports and revert those files, let me know.