Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Remove support for MSVC #52

Merged
merged 13 commits into from
Dec 2, 2021
Merged

RFC: Remove support for MSVC #52

merged 13 commits into from
Dec 2, 2021

Conversation

michael-schwarz
Copy link
Member

We have not tested any of our modifications to CIL with MSVC, and afaik have no intention of adding support for MSVC to Goblint.

This PR removes all support for MSVC from CIL, allowing us to make some things less complex inside CIL.
It also allows us to remove the skinds associated with the proprietary Microsoft try/catch extension, which is not supported by Goblint. This will allow some simplifications in Goblint as well.

I feel it is better to remove all MSVC things than having them around without ever testing if they still work and having no intention of doing so in the future. WDYT?

sim642
sim642 reviewed Nov 29, 2021
View reviewed changes
Copy link
Member

@sim642 sim642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably doesn't make too much of a difference for Goblint, since we already error on TryExcept/TryFinally during CFG construction.

But it's also true that we haven't ever tested or maintained this, so it's better to not pretend either.

@michael-schwarz michael-schwarz mentioned this pull request Nov 29, 2021
Merged
2 tasks
sim642
sim642 reviewed Nov 29, 2021
View reviewed changes
jerhard
jerhard reviewed Dec 2, 2021
View reviewed changes
jerhard
jerhard reviewed Dec 2, 2021
View reviewed changes
@michael-schwarz michael-schwarz merged commit 8383534 into develop Dec 2, 2021
@sim642 sim642 mentioned this pull request Dec 10, 2021
Closed
@sim642 sim642 mentioned this pull request Apr 2, 2022
Closed
@michael-schwarz michael-schwarz mentioned this pull request Apr 4, 2022
Closed
@sim642 sim642 deleted the no_msvc branch May 30, 2022 07:13
@sim642 sim642 added this to the 2.0.0 milestone Jul 17, 2022
sim642 added a commit to sim642/opam-repository that referenced this pull request Aug 12, 2022
@sim642
[new release] goblint-cil (2.0.0)
a9c997a 
CHANGES:

* Wrap library into `GoblintCil` module (goblint/cil#107).
* Remove all MSVC support (goblint/cil#52, goblint/cil#88).
* Port entire build process from configure/make to dune (goblint/cil#104).
* Add C11 `_Generic` support (goblint/cil#48).
* Add C11 `_Noreturn` support (goblint/cil#58).
* Add C11 `_Static_assert` support (goblint/cil#62).
* Add C11 `_Alignof` support (goblint/cil#66).
* Add C11 `_Alignas` support (goblint/cil#93, goblint/cil#108).
* Add partial C11 `_Atomic` support (goblint/cil#61).
* Add `_Float32`, `_Float64`, `_Float32x` and `_Float64x` type support (goblint/cil#8, goblint/cil#60).
* Add Universal Character Names, `char16_t` and `char32_t` type support (goblint/cil#80).
* Change locations to location spans and add additional expression locations (goblint/cil#51).
* Add synthetic marking for CIL-inserted statement locations (goblint/cil#98).
* Expose list of files from line control directives (goblint/cil#73).
* Add parsed location transformation hook (goblint/cil#89).
* Use Zarith for integer constants (goblint/cil#47, goblint/cil#53).
* Fix constant folding overflows (goblint/cil#59).
* Add option to disable constant branch removal (goblint/cil#103).
* Add standalone expression parsing and checking (goblint/cil#97, goblint/cil#96).
* Improve inline function merging (goblint/cil#72, goblint/cil#85, goblint/cil#84, goblint/cil#86).
* Fix some attribute parsing cases (goblint/cil#71, goblint/cil#75, goblint/cil#76, goblint/cil#77).
* Fix global NaN initializers (goblint/cil#78, goblint/cil#79).
* Fix `cilly` binary installation (goblint/cil#99, goblint/cil#100, goblint/cil#102).
* Remove batteries dependency to support OCaml 5 (goblint/cil#106).
@sim642 sim642 mentioned this pull request Aug 12, 2022
Merged
sim642 added a commit to sim642/opam-repository that referenced this pull request Aug 12, 2022
@sim642
[new release] goblint-cil (2.0.0)
fb70853 
CHANGES:

* Wrap library into `GoblintCil` module (goblint/cil#107).
* Remove all MSVC support (goblint/cil#52, goblint/cil#88).
* Port entire build process from configure/make to dune (goblint/cil#104).
* Add C11 `_Generic` support (goblint/cil#48).
* Add C11 `_Noreturn` support (goblint/cil#58).
* Add C11 `_Static_assert` support (goblint/cil#62).
* Add C11 `_Alignof` support (goblint/cil#66).
* Add C11 `_Alignas` support (goblint/cil#93, goblint/cil#108).
* Add partial C11 `_Atomic` support (goblint/cil#61).
* Add `_Float32`, `_Float64`, `_Float32x` and `_Float64x` type support (goblint/cil#8, goblint/cil#60).
* Add Universal Character Names, `char16_t` and `char32_t` type support (goblint/cil#80).
* Change locations to location spans and add additional expression locations (goblint/cil#51).
* Add synthetic marking for CIL-inserted statement locations (goblint/cil#98).
* Expose list of files from line control directives (goblint/cil#73).
* Add parsed location transformation hook (goblint/cil#89).
* Use Zarith for integer constants (goblint/cil#47, goblint/cil#53).
* Fix constant folding overflows (goblint/cil#59).
* Add option to disable constant branch removal (goblint/cil#103).
* Add standalone expression parsing and checking (goblint/cil#97, goblint/cil#96).
* Improve inline function merging (goblint/cil#72, goblint/cil#85, goblint/cil#84, goblint/cil#86).
* Fix some attribute parsing cases (goblint/cil#71, goblint/cil#75, goblint/cil#76, goblint/cil#77).
* Fix global NaN initializers (goblint/cil#78, goblint/cil#79).
* Fix `cilly` binary installation (goblint/cil#99, goblint/cil#100, goblint/cil#102).
* Remove batteries dependency to support OCaml 5 (goblint/cil#106).
@michael-schwarz michael-schwarz mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sim642 sim642 sim642 approved these changes

@jerhard jerhard jerhard approved these changes

@vogler vogler Awaiting requested review from vogler

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-schwarz @sim642 @jerhard