Fix TCompLoop
printing being stateful
#134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when using
d_plaintype
(or any other plain printing which includes the type) twice in a row on a recursive struct, the first output hasTComp
outside andTCompLoop
on the fields:Due to the statefulness of the plain printer, a second call with exactly the same type already has
TCompLoop
outside:This is annoying for incremental analysis in Goblint, where messages will differ only in this aspect because the incremental run will skip over some earlier evaluation that made the first call, moving the first call with the different output to a different place. It shows spurious differences in
messagesCompare
.By removing the
compinfo
after recursing, the plain printer becomes functionally pure, so all calls consistently print the first output from above.