-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCaml DSL for specifying LibraryFunctions
#720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6d618aa.
reach is true only if deref is also.
Invalidation should also be done for special (non-Unknown) functions that symb_locks doesn't handle before.
Spawning should also be done for special (non-Unknown) functions that forkfun doesn't handle before.
This now works using standard invalidation.
5 tasks
jerhard
reviewed
Jun 7, 2022
jerhard
reviewed
Jun 9, 2022
jerhard
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to address #719 by designing an OCaml DSL, which allows specifying
LibraryFunctions
such that all the problems mentioned in the issue are avoided and all the goals are fulfilled.The DSL implementation is a mixture of the following:
Ast_pattern
: https://github.com/ocaml-ppx/ppxlib/blob/main/src/ast_pattern.ml. The three-type-parameter continuation-based internals of the patterns are hidden from actually specifying functions.The DSL in
LibraryDsl
is just a convenient way to construct newly-introducedLibraryDesc
objects, which combine the corresponding classify function, invalidate actions (with more precision) and other function-related attributes (e.g. being thread unsafe #723 or invalidating all globals).The usage is (hopefully sufficiently) extensively documented both in the OCaml code and in the developer documentation.
The usage can be seen at the beginning of
LibraryFunctions
andLibraryDslTest
.TODO
LibraryDesc
.LibraryDsl
.Add selection for separate specifications lists.To be done in the future, when all old-style specifications have been ported.