Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate apron, apron2, termination and OSX "Excellent: ignored check"-s #1428

Merged
merged 17 commits into from
Apr 30, 2024
Merged

Investigate apron, apron2, termination and OSX "Excellent: ignored check"-s #1428

merged 17 commits into from
Apr 30, 2024

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Apr 23, 2024 •
edited
Loading

See #1425.

I went over all the apron, apron2, termination and OSX instances from the issue and adapted the tests in one of the ways:

  1. Remove TODO because we are soundly more precise now.
  2. Remove TODO because we changed defaults to the passing one.
  3. Adapt test to check originally intended aspect which we haven't solved but we became more precise due to orthogonal reasons.
  4. Make OSX-dependent checks variable-based, so we can force them to pass on OSX at the same line as the Linux check.

sim642 added 10 commits April 22, 2024 17:11
@sim642
Remove TODOs from 36-apron/21-traces-cluster-based (issue #1425)
abb3ac5
@sim642
Remove TODO from 36-apron/22-traces-write-centered-vs-mutex-meet (issue
6abbd8a 
#1425)
@sim642
Remove TODO from 36-apron/38-branch-global (issue #1425)
c586072
@sim642
Update TODO in 36-apron/91-mine14-5b-no-threshold (issue #1425)
d0364db
@sim642
Disable expRelation in 36-apron/34-large-bigint
3e8882b 
This makes the check meaningful again.
@sim642
Fix 36-apron/34-large-bigint to not pass due to def_exc range (issue #…
8e2004f 
…1425)
@sim642
Remove TODO from 36-apron/42-threadenter-arg (issue #1425)
29de6bc
@sim642
Enable base protection-atomic in 46-apron2/75-mutex_with_ghosts (issue …
fa55034 
…#1425)

This was used before f754362 changed the default.
@sim642
Remove TODO from 78-termination/25-leave-loop-goto-terminating (issue #…
d5081d7 
…1425)

Passing again since f81ca2c.
@sim642
Remove TODO from 78-termination/28-do-while-continue-terminating (issue
46b9096 
#1425)

Passing again since 5d291ca.
It provides more precise locations.
@sim642 sim642 added cleanup Refactoring, clean-up testing precision labels Apr 23, 2024
@sim642 sim642 added this to the v2.4.0 milestone Apr 23, 2024
@sim642 sim642 mentioned this pull request Apr 23, 2024
Open
19 tasks
@sim642 sim642 changed the title Investigate apron, apron2 and termination "Excellent: ignored check"-s Investigate apron, apron2, termination and OSX "Excellent: ignored check"-s Apr 25, 2024
michael-schwarz
michael-schwarz approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@michael-schwarz michael-schwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the comments are addressed, this should be good to go!

@sim642 sim642 merged commit 2fa4f55 into master Apr 30, 2024
19 checks passed
@sim642 sim642 deleted the todo-passing branch April 30, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-schwarz michael-schwarz michael-schwarz approved these changes

@jerhard jerhard Awaiting requested review from jerhard

Assignees
No one assigned
Labels
cleanup Refactoring, clean-up precision testing
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sim642 @michael-schwarz