(BIDS-2548) add total deposits columns #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR prepares everything for the reexport but BIDS-2769 has to be done first to get rid of day -1 which contains deposits. |
LuccaBitfly
approved these changes
Nov 27, 2023
| SELECT 'down SQL query - remove total deposits count and amount columns from stats'; | ||
| ALTER TABLE validator_stats DROP COLUMN IF EXISTS deposits_total; | ||
| ALTER TABLE validator_stats DROP COLUMN IF EXISTS deposits_amount_total; | ||
| -- +goose StatementEnd |
There was a problem hiding this comment.
Minor:
I think this means that file should end with newline?
There was a problem hiding this comment.
We have some migration files that don't end on a newline but since most of them do I added it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at ba02a37
This pull request adds two new metrics to the validator statistics: the total number and amount of deposits made by each validator. These metrics are stored in the
validator_statstable, exported in the CSV file, and represented in theExporterValidatorStatsstruct.