Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix main field in package.json; → 0.11.1 #109

Merged
merged 1 commit into from
Apr 25, 2016
Merged

Fix main field in package.json; → 0.11.1 #109

merged 1 commit into from
Apr 25, 2016

Conversation

IvanSanchez
Copy link
Member

@IvanSanchez IvanSanchez commented Apr 25, 2016 •
edited
Loading

Fixes a build bug introduced in 18b7ffa#diff-ff6e5f22a9c7e66987b19c0199636480R9 : the filename of the rolled-up file is now gobble.js instead of index.js.

This is making gobble-cli fail, as it cannot find the script pointed by the main field in gobble's package.json

@fskreuz
Copy link

fskreuz commented Apr 25, 2016

So it's related to this? gobblejs/gobble-cli#20

@IvanSanchez
Copy link
Member Author

Not only it's related to: it fixes it.

@IvanSanchez
Copy link
Member Author

I'll let @Rich-Harris do a quick review and push a new version to NPM.

@IvanSanchez IvanSanchez mentioned this pull request Apr 25, 2016
Closed
@Rich-Harris Rich-Harris merged commit 2f6198a into master Apr 25, 2016
@Rich-Harris
Copy link
Contributor

Whoops! Thanks @IvanSanchez, released

@Rich-Harris Rich-Harris deleted the pkg-main branch April 25, 2016 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanSanchez @fskreuz @Rich-Harris