Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File transformer nodes sometimes erroneously report successful completion #42

Closed
Rich-Harris opened this issue Apr 3, 2015 · 0 comments · Fixed by #43
Closed

File transformer nodes sometimes erroneously report successful completion #42

Rich-Harris opened this issue Apr 3, 2015 · 0 comments · Fixed by #43
Labels
bug regression

Comments

@Rich-Harris
Copy link
Contributor

Leaving some breadcrumbs for myself:

This is related to #41 (or more specifically the fix thereof) - if a file transformation is aborted, this callback is called with no argument, which looks like success when it's actually a failure. As a result, the ready promise fulfils, and any downstream nodes start their transformations with an incomplete inputdir.
Rich-Harris added a commit that referenced this issue Apr 3, 2015
@Rich-Harris
WIP solution to #42
064c9da
@Rich-Harris Rich-Harris mentioned this issue Apr 4, 2015
Merged
Rich-Harris added a commit that referenced this issue Apr 4, 2015
@Rich-Harris
Merge pull request #43 from gobblejs/gh-42
350770d 
more robust invalidation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

more robust invalidation gobblejs/gobble
1 participant
@Rich-Harris