web: ESBuild performance + Live reload #13026
Merged
+534
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GirlBossRush
added
enhancement
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13026 +/- ##
==========================================
+ Coverage 92.62% 92.67% +0.04%
==========================================
Files 792 792
Lines 40222 40222
==========================================
+ Hits 37256 37274 +18
+ Misses 2966 2948 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rissson
changed the title
GirlBossRush
force-pushed
the
live-reload-v1
branch
from
ab95483 to
ce57e1a
Compare
Signed-off-by: Teffen Ellis <[email protected]>
BeryJu
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR features two primary improvements to our ESBuild script:
Use of ESBuild's built-in watcher
Previously, we used Chokidar to track file changes ourselves, building all entry points if any file is changed. We can now limit rebuilds to the specific files within each entry, additionally getting a second performance boost from ESbuild's context caching.
Live-reload
Previously, modifying the front-end required manually refreshing the page, often several times in a a row to ensure the reload "caught" ESBuild's compiled output. ESBuild events are now relayed to the browser, allowing for automatic reloading.
This also includes a few ease of use behaviors such as...
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)