Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the XML encoded http.ErrorResponse #3398

Merged
merged 3 commits into from
Oct 21, 2023

Conversation

tchssk
Copy link
Member

@tchssk tchssk commented Oct 19, 2023

Related to goadesign/clue#284

The XML encoded http.ErrorResponse is formed as follows:

<ErrorResponse>
        <name>name</name>
        <id>id</id>
        <message>message</message>
        <temporary>false</temporary>
        <timeout>false</timeout>
        <fault>false</fault>
</ErrorResponse>

But I think the top level element should be like this:

<error>
        <name>name</name>
        <id>id</id>
        <message>message</message>
        <temporary>false</temporary>
        <timeout>false</timeout>
        <fault>false</fault>
</error>

It can be restored the previous form:

goahttp.ErrorResponseXMLName = xml.Name{Local: "ErrorResponse"}

@tchssk
Copy link
Member Author

tchssk commented Oct 19, 2023

DeepSource again...

@tchssk tchssk marked this pull request as ready for review October 19, 2023 16:21
@raphael
Copy link
Member

raphael commented Oct 19, 2023

Thank you, looks good. Looks like one of the issues reported by DeepSource could be addressed (https://app.deepsource.com/gh/goadesign/goa/run/68b2c44c-c727-40d1-8edf-63efacc2a6c9/go/RVV-B0012?listindex=1). The other issue was already there but maybe we can take this opportunity to fix it too (i.e. change the receivers for the Marshal methods to be pointers).

@raphael raphael merged commit d3789bd into goadesign:v3 Oct 21, 2023
@tchssk tchssk deleted the http-errorresponse-marshalxml branch October 21, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants