update github actions. cleanup and edits. #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbean
commented
Apr 27, 2024
•
jeffbean
commented
- action/stale: debug mode shows deprecation warning of older version. update to v9 (current latest)
- integration_test and unittest workflows: update tiggers to prevent double trigger on PR update.
- action/codecov: update version, and settings for action.
- action/codecov: if condition on the test matrix to only run on the first matric job, removing the upload to happen for each combo in the test matrix.
- codecov.yaml: update threshold to what we have now at 76%. also up the patch to 80%.
debug mode shows deprecation warning of older version. update to v9 (current latest)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 76.19% 76.62% +0.43%
==========================================
Files 7 7
Lines 1193 1322 +129
==========================================
+ Hits 909 1013 +104
- Misses 195 217 +22
- Partials 89 92 +3 ☔ View full report in Codecov by Sentry. |
Update the code coverage job to only run on one matrix so we stop uploading 4 copies of the same coverage report. also cleanup actions from the github action linting suggestions.
we don't want double triggers on PRs. https://github.com/orgs/community/discussions/26276
jeffbean
changed the title
update thresholds for codecov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.