This repository was archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
fix: execute after hook. #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2017
lunny
suggested changes
Jan 20, 2017
| @@ -226,7 +226,8 @@ func (session *Session) Delete(bean interface{}) (int64, error) { | |||
| session.afterDeleteBeans[bean] = &afterClosures | |||
| } | |||
| } else { | |||
| if _, ok := interface{}(bean).(AfterInsertProcessor); ok { | |||
| if processor, ok := interface{}(bean).(AfterInsertProcessor); ok { | |||
|
@lunny Please review again. |
|
Could you help add some tests PR int github.com/go-xorm/tests? |
|
@lunny See the PR go-xorm/tests#16 |
lunny
approved these changes
Jan 25, 2017
|
@appleboy could you rebase this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some bugs from go-gitea/gitea#677 (comment)
cc @lunny