Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPM attestation refactor, add tests #60

Merged
merged 6 commits into from
Oct 12, 2022
Merged

TPM attestation refactor, add tests #60

merged 6 commits into from
Oct 12, 2022

Conversation

aseigler
Copy link
Collaborator

  • Switch to using Google's go-tpm library
  • Fix return values to align with WebAuthn spec
  • Add plenty of additional TPM tests

@aseigler aseigler requested a review from a team as a code owner October 11, 2022 01:05
james-d-elliott
james-d-elliott approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@james-d-elliott james-d-elliott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I'd already looked over most of this already). Surprised Renovate broke that dep. I should have more carefully checked it.

@james-d-elliott james-d-elliott merged commit cdfc867 into go-webauthn:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-d-elliott james-d-elliott james-d-elliott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aseigler @james-d-elliott