Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buildkite/yaml to enable anchors in stages #12

Merged
merged 2 commits into from
Nov 14, 2019

Conversation

jbrockopp
Copy link
Contributor

@jbrockopp jbrockopp commented Nov 14, 2019

Directly in relation to:

go-yaml/yaml#184

The solution to use buildkite/yaml is documented in the thread.

NOTE:

We vendor directly from the commit:

(0caa5f0796e36057e59d6782832a9c774f457842)

rather then the release:

(v2.2.0)

because of a Go module versioning issue:

https://github.com/golang/go/wiki/Modules#semantic-import-versioning

If the module is version v2 or higher, the major version of the module must be included as a /vN at the end of the module paths used in go.mod files (e.g., module github.com/my/mod/v2, require github.com/my/mod/v2 v2.0.1) and in the package import path (e.g., import "github.com/my/mod/v2/mypkg"). This includes the paths used in go get commands (e.g., go get github.com/my/mod/[email protected]. Note there is both a /v2 and a @v2.0.1 in that example. One way to think about it is that the module name now includes the /v2, so include /v2 whenever you are using the module name).

$ go get -u github.com/buildkite/[email protected]
go: finding github.com/buildkite/yaml v2.2.0
go: finding github.com/buildkite/yaml v2.2.0
go get github.com/buildkite/[email protected]: github.com/buildkite/[email protected]: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2

@jbrockopp jbrockopp added the bug Indicates a bug label Nov 14, 2019
@jbrockopp jbrockopp requested a review from a team as a code owner November 14, 2019 18:53
@jbrockopp jbrockopp self-assigned this Nov 14, 2019
Copy link

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants