Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): bust template cache on Duplicate #1249

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

ecrupper
Copy link
Contributor

When we don't set this to an empty map, it'll use old sources of templates

@ecrupper ecrupper requested a review from a team as a code owner January 30, 2025 14:28
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.55%. Comparing base (8f47ad9) to head (e96ded3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1249   +/-   ##
=======================================
  Coverage   56.55%   56.55%           
=======================================
  Files         629      629           
  Lines       35619    35619           
=======================================
  Hits        20146    20146           
  Misses      14792    14792           
  Partials      681      681           
Files with missing lines Coverage Δ
compiler/native/native.go 80.74% <100.00%> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit abe0d5f into main Jan 30, 2025
9 of 12 checks passed
@ecrupper ecrupper deleted the fix/bust-template-cache-on-duplicate branch January 30, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants