Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): missing fields in api conversion and func renames #1130

Merged
merged 10 commits into from
May 16, 2024

fix: comment typo

0735bd4
Select commit
Loading
Failed to load commit list.
Merged

fix(settings): missing fields in api conversion and func renames #1130

fix: comment typo
0735bd4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 14, 2024 in 0s

68.06% (target 90.00%)

View this Pull Request on Codecov

68.06% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 68.06%. Comparing base (927dc71) to head (0735bd4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
- Coverage   68.08%   68.06%   -0.02%     
==========================================
  Files         410      410              
  Lines       13691    13699       +8     
==========================================
+ Hits         9321     9324       +3     
- Misses       3836     3841       +5     
  Partials      534      534              
Files Coverage Δ
api/types/settings/platform.go 70.90% <57.14%> (-2.63%) ⬇️