Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mock): correct type for mock response #1121

Merged
merged 1 commit into from
May 6, 2024
Merged

fix(mock): correct type for mock response #1121

merged 1 commit into from
May 6, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented May 6, 2024

Dashboards vs Dash Cards

@ecrupper ecrupper requested a review from a team as a code owner May 6, 2024 15:11
@codecov Codecov
Copy link

codecov bot commented May 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.60%. Comparing base (993a937) to head (2873d6a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1121   +/-   ##
=======================================
  Coverage   67.60%   67.60%           
=======================================
  Files         392      392           
  Lines       13063    13063           
=======================================
  Hits         8831     8831           
  Misses       3725     3725           
  Partials      507      507
Files Coverage Δ
mock/server/dashboard.go 0.00% <0.00%> (ø)

KellyMerrick
KellyMerrick approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 8ad1234 into main May 6, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the fix/dashmock branch May 6, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhuynh94 timhuynh94 timhuynh94 approved these changes

@KellyMerrick KellyMerrick KellyMerrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecrupper @timhuynh94 @KellyMerrick