-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return code in CompileAndPublish rather than handleError #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1107 +/- ##
==========================================
+ Coverage 65.22% 65.33% +0.11%
==========================================
Files 371 371
Lines 11961 11940 -21
==========================================
Hits 7801 7801
+ Misses 3657 3636 -21
Partials 503 503
|
plyr4
reviewed
Apr 15, 2024
plyr4
reviewed
Apr 15, 2024
plyr4
reviewed
Apr 15, 2024
wass3rw3rk
requested changes
Apr 15, 2024
plyr4
approved these changes
Apr 16, 2024
wass3rw3rk
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'll be easier to follow that
CompileAndPublish
errors are returned with a code to handle rather than handle them itself.I also made all the responses match across create, restart, and PostWebhook:
Open to suggestions on that, but the inconsistencies should be addressed at least.