refactor: consistent import order #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
=======================================
Coverage 64.47% 64.47%
=======================================
Files 370 370
Lines 11790 11790
=======================================
Hits 7602 7602
Misses 3671 3671
Partials 517 517
|
wass3r
changed the title
|
I like it |
|
@plyr4 do you like it enough for it to be a linter rule that will gently remind folks that their import order might be ... out of order? golangci-lint does support |
|
@wass3rw3rk yeah it feels like a reasonable linter rule, especially if we can add it to our golangci-lint action |
|
can we supply the configurations you used in as a file so we can commit the parameters to source? im not seeing anything in their docs, so maybe its enough to just put the command in our dev docs? |
|
@wass3rw3rk oh yeah exactly! i was thinking of it from "run gci with config" and not "run golangci-lint with gci config". that is great |
ecrupper
previously approved these changes
Mar 6, 2024
cognifloyd
reviewed
Mar 8, 2024
Co-authored-by: Jacob Floyd <[email protected]>
cognifloyd
previously approved these changes
Mar 9, 2024
timhuynh94
approved these changes
Apr 11, 2024
ecrupper
approved these changes
Apr 11, 2024
wass3rw3rk
added a commit
to go-vela/types
that referenced
this pull request
Apr 11, 2024
wass3rw3rk
added a commit
to go-vela/sdk-go
that referenced
this pull request
Apr 11, 2024
wass3rw3rk
added a commit
to go-vela/types
that referenced
this pull request
Apr 11, 2024
wass3rw3rk
added a commit
to go-vela/cli
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just testing the waters to see what folks think. maybe i'm not the only one bothered by import order being all over the place? i used gci via
gci write --custom-order -s standard -s default -s blank -s dot -s alias -s "prefix(github.com/go-vela)" .gci write --custom-order -s standard -s default -s blank -s dot -s "prefix(github.com/go-vela)" .(UPDATED - see comments) to format all of these. it's a little opinionated. was mostly going for std lib, third party, and our own imports last. we can add this to golangci as a check, but i didn't do it here (yet) to get feedback first.if we like it, we can apply to all repos.