linter

api/build/restart.go

@@ -348,7 +348,7 @@ func RestartBuild(c *gin.Context) {
 
 	d.SetBuilds(build)
 
-	_, err = database.FromContext(c).UpdateDeployment(c, d)
+	_, err = database.FromContext(c).UpdateDeployment(d)
 	if err != nil {
 		logger.Errorf("unable to set update deployment for build %s: %v", entry, err)
 	}

api/deployment/get.go

@@ -93,7 +93,7 @@ func GetDeployment(c *gin.Context) {
 	}
 
 	// send API call to database to capture the deployment
-	d, err := database.FromContext(c).GetDeployment(c, int64(number))
+	d, err := database.FromContext(c).GetDeployment(int64(number))
 	if err != nil {
 		// send API call to SCM to capture the deployment
 		dep, err = scm.FromContext(c).GetDeployment(ctx, u, r, int64(number))

api/webhook/post.go

@@ -700,7 +700,7 @@ func PostWebhook(c *gin.Context) {
 			}
 		} else {
 			d.SetBuilds(builds)
-			_, err := database.FromContext(c).UpdateDeployment(c, d)
+			_, err := database.FromContext(c).UpdateDeployment(d)
 			if err != nil {
 				retErr := fmt.Errorf("%s: failed to update deployment %s/%d: %w", baseErr, repo.GetFullName(), d.GetNumber(), err)
 				util.HandleError(c, http.StatusInternalServerError, retErr)

database/deployment/delete.go

@@ -1,20 +1,16 @@
-// Copyright (c) 2022 Target Brands, Inc. All rights reserved.
-//
-// Use of this source code is governed by the LICENSE file in this repository.
+// SPDX-License-Identifier: Apache-2.0
 
 package deployment
 
 import (
-	"context"
-
 	"github.com/go-vela/types/constants"
 	"github.com/go-vela/types/database"
 	"github.com/go-vela/types/library"
 	"github.com/sirupsen/logrus"
 )
 
 // DeleteDeployment deletes an existing deployment from the database.
-func (e *engine) DeleteDeployment(ctx context.Context, d *library.Deployment) error {
+func (e *engine) DeleteDeployment(d *library.Deployment) error {
 	e.logger.WithFields(logrus.Fields{
 		"deployment": d.GetID(),
 	}).Tracef("deleting deployment %d in the database", d.GetID())

database/deployment/delete_test.go

@@ -68,7 +68,7 @@ func TestDeployment_Engine_DeleteDeployment(t *testing.T) {
 	// run tests
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			err = test.database.DeleteDeployment(context.TODO(), _deploymentOne)
+			err = test.database.DeleteDeployment(_deploymentOne)
 
 			if test.failure {
 				if err == nil {

database/deployment/deployment.go

@@ -1,6 +1,4 @@
-// Copyright (c) 2022 Target Brands, Inc. All rights reserved.
-//
-// Use of this source code is governed by the LICENSE file in this repository.
+// SPDX-License-Identifier: Apache-2.0
 
 package deployment
 

database/deployment/get.go

@@ -1,11 +1,8 @@
-// Copyright (c) 2022 Target Brands, Inc. All rights reserved.
-//
-// Use of this source code is governed by the LICENSE file in this repository.
+// SPDX-License-Identifier: Apache-2.0
 
 package deployment
 
 import (
-	"context"
 	"strconv"
 
 	"github.com/go-vela/types/constants"
@@ -14,7 +11,7 @@ import (
 )
 
 // GetDeployment gets a deployment by ID from the database.
-func (e *engine) GetDeployment(ctx context.Context, id int64) (*library.Deployment, error) {
+func (e *engine) GetDeployment(id int64) (*library.Deployment, error) {
 	e.logger.Tracef("getting deployment %d from the database", id)
 
 	// variable to store query results

database/deployment/get_test.go

@@ -75,7 +75,7 @@ func TestDeployment_Engine_GetDeployment(t *testing.T) {
 	// run tests
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			got, err := test.database.GetDeployment(context.TODO(), 1)
+			got, err := test.database.GetDeployment(1)
 
 			if test.failure {
 				if err == nil {

database/deployment/interface.go

@@ -35,15 +35,15 @@ type DeploymentInterface interface {
 	// CreateDeployment defines a function that creates a new deployment.
 	CreateDeployment(context.Context, *library.Deployment) (*library.Deployment, error)
 	// DeleteDeployment defines a function that deletes an existing deployment.
-	DeleteDeployment(context.Context, *library.Deployment) error
+	DeleteDeployment(*library.Deployment) error
 	// GetDeployment defines a function that gets a deployment by ID.
-	GetDeployment(context.Context, int64) (*library.Deployment, error)
+	GetDeployment(int64) (*library.Deployment, error)
 	// GetDeploymentForRepo defines a function that gets a deployment by repo ID and number.
 	GetDeploymentForRepo(context.Context, *library.Repo, int64) (*library.Deployment, error)
 	// ListDeployments defines a function that gets a list of all deployments.
 	ListDeployments(context.Context) ([]*library.Deployment, error)
 	// ListDeploymentsForRepo defines a function that gets a list of deployments by repo ID.
 	ListDeploymentsForRepo(context.Context, *library.Repo, int, int) ([]*library.Deployment, error)
 	// UpdateDeployment defines a function that updates an existing deployment.
-	UpdateDeployment(context.Context, *library.Deployment) (*library.Deployment, error)
+	UpdateDeployment(*library.Deployment) (*library.Deployment, error)
 }

database/deployment/update.go

@@ -5,16 +5,14 @@
 package deployment
 
 import (
-	"context"
-
 	"github.com/go-vela/types/constants"
 	"github.com/go-vela/types/database"
 	"github.com/go-vela/types/library"
 	"github.com/sirupsen/logrus"
 )
 
 // UpdateDeployment updates an existing deployment in the database.
-func (e *engine) UpdateDeployment(ctx context.Context, d *library.Deployment) (*library.Deployment, error) {
+func (e *engine) UpdateDeployment(d *library.Deployment) (*library.Deployment, error) {
 	e.logger.WithFields(logrus.Fields{
 		"deployment": d.GetID(),
 	}).Tracef("updating deployment %d in the database", d.GetID())

database/deployment/update_test.go

@@ -70,7 +70,7 @@ WHERE "id" = $13`).
 	// run tests
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			_, err = test.database.UpdateDeployment(context.TODO(), _deploymentOne)
+			_, err = test.database.UpdateDeployment(_deploymentOne)
 
 			if test.failure {
 				if err == nil {

database/integration_test.go

@@ -560,13 +560,13 @@ func testDeployments(t *testing.T, db Interface, resources *Resources) {
 
 	// update the deployments
 	for _, deployment := range resources.Deployments {
-		_, err = db.UpdateDeployment(context.TODO(), deployment)
+		_, err = db.UpdateDeployment(deployment)
 		if err != nil {
 			t.Errorf("unable to update deployment %d: %v", deployment.GetID(), err)
 		}
 
 		// lookup the deployment by ID
-		got, err := db.GetDeployment(context.TODO(), deployment.GetID())
+		got, err := db.GetDeployment(deployment.GetID())
 		if err != nil {
 			t.Errorf("unable to get deployment %d by ID: %v", deployment.GetID(), err)
 		}
@@ -579,7 +579,7 @@ func testDeployments(t *testing.T, db Interface, resources *Resources) {
 
 	// delete the deployments
 	for _, deployment := range resources.Deployments {
-		err = db.DeleteDeployment(context.TODO(), deployment)
+		err = db.DeleteDeployment(deployment)
 		if err != nil {
 			t.Errorf("unable to delete hook %d: %v", deployment.GetID(), err)
 		}