This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
fix(cancel): remove SIGTERM in favor of executor.DestroyBuild #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 75.31% 75.61% +0.30%
==========================================
Files 29 29
Lines 1503 1497 -6
==========================================
Hits 1132 1132
+ Misses 290 284 -6
Partials 81 81
|
matt-fevold
approved these changes
Feb 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes go-vela/community#201
Sending a SIGTERM to cancel the executor actually terminates the entire worker. In the future Go may support separate PIDs per thread golang/go#19326