Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checker): use only one checker at the same time to improve perf #2031

Merged
merged 3 commits into from
Feb 8, 2025

Conversation

vmaerten
Copy link
Member

fixes #2029

@pd93 Before, both {{.TIMESTAMP}} and {{.CHECKSUM}} were available in status, but according to our documentation, only one should be available depending on the chosen method.

cf : https://taskfile.dev/usage/#using-programmatic-checks-to-indicate-a-task-is-up-to-date

@vmaerten vmaerten marked this pull request as ready for review January 30, 2025 11:53
@vmaerten vmaerten requested review from andreynering and pd93 January 30, 2025 11:53
Copy link
Member

@andreynering andreynering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

@pd93 pd93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice one

@vmaerten vmaerten merged commit c995fe6 into main Feb 8, 2025
14 checks passed
@vmaerten vmaerten deleted the fix/use-only-one-checker-at-the-same-time branch February 8, 2025 16:34
vmaerten added a commit that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.41.0 Regression in sources behavior cause all files to be read even with method: timestamp
3 participants