Add deprecated message to NullTime #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shogo82148
commented
Aug 13, 2020
README.md
Outdated
|
|
||
| Alternatively you can use the [`NullTime`](https://godoc.org/github.com/go-sql-driver/mysql#NullTime) type as the scan destination, which works with both `time.Time` and `string` / `[]byte`. | ||
|
|
||
| s |
There was a problem hiding this comment.
oops, I will remove it.
There was a problem hiding this comment.
It is mistake of saving the document (⌘+S).
methane
previously approved these changes
Aug 13, 2020
methane
approved these changes
Aug 16, 2020
|
Thanks! |
tz70s
pushed a commit
to tz70s/mysql
that referenced
this pull request
Sep 5, 2020
* Add deprecated message to NullTime * remove NullTime from README
tz70s
pushed a commit
to tz70s/mysql
that referenced
this pull request
Sep 5, 2020
* Add deprecated message to NullTime * remove NullTime from README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #960
database/sql has a NullTime type now, which should be used instead.
In addition,
mysql.NullTimedoesn't honor the loc DSN parameter.Checklist