Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade minimum Go version #69

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Feb 8, 2025

The minimum Go version is a hard requirement for library consumers.

The Go version inside toolchain defined the Go version used to compile and doesn't affect lib consumers.

The minimum Go version can be either a "family name" (e.g. 1.22) or a "release name" (e.g. 1.22.0). It's important not to update the patch element to avoid forcing lib consumers to also update to this patched version.

The minimum Go version should only be used to define the minimum language version used to write and compile a module.

The toolchain version must be a prefixed "release name" (e.g. go1.22.0).

Related to #62 (comment)
Related to #68

@ldez ldez changed the title fix: downgarde minimum Go version fix: downgrade minimum Go version Feb 8, 2025
@ldez ldez force-pushed the fix/min-go-version branch from 8bf3dff to ad089e2 Compare February 8, 2025 17:38
@tmzane tmzane self-requested a review February 9, 2025 10:34
@tmzane
Copy link
Member

tmzane commented Feb 9, 2025

I thought that it's safe for linters to use to next Go version once golangci-lint uses it. Thanks for the clarification.

@tmzane tmzane changed the title fix: downgrade minimum Go version chore: downgrade minimum Go version Feb 9, 2025
@tmzane tmzane merged commit 6760a8e into go-simpler:main Feb 9, 2025
8 checks passed
@ldez ldez deleted the fix/min-go-version branch February 9, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants