Remove clean up on extend fail #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@palcalde Thank you! I am sorry, I thought I had hit the "Comment" button after merging. But it didn't go through for some reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This is a fix for #149. I realized the clean up I added is removing keys in all redises if just one of the redises fail to extend (for example with a network error). This means in case of a single redis error we'll release a previously held lock even if we were able to extend in a quorum redises fine.
I can add the release after the
actOnPoolAsync, however, the complexity in the code is not worth the benefit. So I just removed the code that released locks in case of errors. Locks will anyway be released after TTL expires.Let me know if this makes sense.
Thanks!