Allow latitude/longitude validation for numeric values #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaMin0
force-pushed
the
feature/numeric_geo_coords
branch
from
c2f8e2c to
52ea448
Compare
deankarn
reviewed
Jan 28, 2019
baked_in.go
Outdated
| @@ -304,12 +304,12 @@ func isSSN(fl FieldLevel) bool { | |||
|
|
|||
| // IsLongitude is the validation function for validating if the field's value is a valid longitude coordinate. | |||
| func isLongitude(fl FieldLevel) bool { | |||
| return longitudeRegex.MatchString(fl.Field().String()) | |||
| return longitudeRegex.MatchString(fmt.Sprint(fl.Field().Interface())) | |||
There was a problem hiding this comment.
like the change, it would be nice if you could add a type switch as it will allow the conversion from int to string to be much more efficient eg.
Line 193 in 52ea448
There was a problem hiding this comment.
Did a small benchmark to compare and you're right. Check the latest commits.
deankarn
approved these changes
Jan 28, 2019
fairyhunter13
added a commit
to fairyhunter13/validator
that referenced
this pull request
Jul 12, 2020
…coords Allow latitude/longitude validation for numeric values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that you've checked the boxes below before you submit PR:
Change Details:
strings.@go-playground/admins