-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix registration of dev provider in Service.authMiddleware.Providers #201
Conversation
Now it is possible to have a configuration, where only one single dev provider is enabled. Providers were not registered into Service.authMiddleware.Providers slice in the Service.AddDevProvider() and Service.AddAppleProvider() methods before.
I reviewed the changes and I think they are not breaking anything. The only thing I still do not understand is the original issue, could you please describe it in more detail, and maybe provide a code snippet which reproduces it? Ideally a test which reproduces the problem in master. |
Pull Request Test Coverage Report for Build 9349982315Details
💛 - Coveralls |
I was trying to use this auth lib in my dev environment, and only a single dev provider was configured there. The new and modified version of |
Pull Request Test Coverage Report for Build 9387863023Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9387863020Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx
There was one minor problem related to the dev and Apple providers registration.
Now it is possible to have a configuration,
where only one single dev provider is enabled.
Providers were not registered into
Service.authMiddleware.Providers
slice in theService.AddDevProvider()
andService.AddAppleProvider()
methods before.This worked before, because other providers were registered at the same time, and
authMiddleware.Providers
slice was reassigned by other methods.