Merge pull request #203 from iRay/fix-logout-empty-header

Set proper "content-type" while calling JwtService.Reset()
go-pkgz · Jun 18, 2024 · 733697d · 733697d
2 parents e0ea38d + baf4355
commit 733697d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 0 deletions.
diff --git a/auth_test.go b/auth_test.go
@@ -292,6 +292,7 @@ func TestLogout(t *testing.T) {
 	resp, err = client.Get("http://127.0.0.1:8089/auth/logout")
 	require.Nil(t, err)
 	assert.Equal(t, 200, resp.StatusCode)
+	assert.Equal(t, "application/json; charset=utf-8", resp.Header.Get("Content-Type"))
 	defer resp.Body.Close()
 
 	resp, err = client.Get("http://127.0.0.1:8089/private")

diff --git a/token/jwt.go b/token/jwt.go
@@ -321,6 +321,8 @@ func (j *Service) Reset(w http.ResponseWriter) {
 	xsrfCookie := http.Cookie{Name: j.XSRFCookieName, Value: "", HttpOnly: false, Path: "/", Domain: j.JWTCookieDomain,
 		MaxAge: -1, Expires: time.Unix(0, 0), Secure: j.SecureCookies, SameSite: j.SameSite}
 	http.SetCookie(w, &xsrfCookie)
+
+	w.Header().Set("Content-Type", "application/json; charset=utf-8")
 }
 
 // checkAuds verifies if claims.Audience in the list of allowed by audReader

diff --git a/v2/auth_test.go b/v2/auth_test.go
@@ -292,6 +292,7 @@ func TestLogout(t *testing.T) {
 	resp, err = client.Get("http://127.0.0.1:8089/auth/logout")
 	require.Nil(t, err)
 	assert.Equal(t, 200, resp.StatusCode)
+	assert.Equal(t, "application/json; charset=utf-8", resp.Header.Get("Content-Type"))
 	defer resp.Body.Close()
 
 	resp, err = client.Get("http://127.0.0.1:8089/private")

diff --git a/v2/token/jwt.go b/v2/token/jwt.go
@@ -321,6 +321,8 @@ func (j *Service) Reset(w http.ResponseWriter) {
 	xsrfCookie := http.Cookie{Name: j.XSRFCookieName, Value: "", HttpOnly: false, Path: "/", Domain: j.JWTCookieDomain,
 		MaxAge: -1, Expires: time.Unix(0, 0), Secure: j.SecureCookies, SameSite: j.SameSite}
 	http.SetCookie(w, &xsrfCookie)
+
+	w.Header().Set("Content-Type", "application/json; charset=utf-8")
 }
 
 // checkAuds verifies if claims.Audience in the list of allowed by audReader