Export DateTimeFormats variable used by ParseDateTime() #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes go-openapi#70 This commit exports the DateTimeFormats variable so that users can modify the set of formats used by ParseDateTime, as in this example: strfmt.DateTimeFormats = append(strfmt.DateTimeFormats, "2006-01-02T15:04Z0700") Signed-off-by: Phil Adams <[email protected]>
padamstx
commented
Nov 15, 2020
| @@ -55,25 +55,26 @@ func IsDateTime(str string) bool { | |||
| const ( | |||
| // RFC3339Millis represents a ISO8601 format to millis instead of to nanos | |||
| RFC3339Millis = "2006-01-02T15:04:05.000Z07:00" | |||
| // RFC3339Millis represents a ISO8601 format to millis instead of to nanos | |||
| // RFC3339MillisNoColon represents a ISO8601 format to millis instead of to nanos | |||
There was a problem hiding this comment.
I fixed a few comments to get rid of linter warnings in my IDE :)
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=======================================
Coverage 81.63% 81.63%
=======================================
Files 10 10
Lines 1285 1285
=======================================
Hits 1049 1049
Misses 164 164
Partials 72 72
Continue to review full report at Codecov.
|
casualjim
approved these changes
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70
This commit exports the DateTimeFormats variable so that users
can modify the set of formats used by ParseDateTime, as in this
example:
strfmt.DateTimeFormats = append(strfmt.DateTimeFormats, "2006-01-02T15:04Z0700")
Signed-off-by: Phil Adams [email protected]