Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go.mongodb.org/mongo-driver version to v1.4.2 #69

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Upgrade go.mongodb.org/mongo-driver version to v1.4.2 #69

merged 1 commit into from
Oct 28, 2020

Conversation

bvwells
Copy link
Contributor

@bvwells bvwells commented Oct 28, 2020

Upgrade go.mongodb.org/mongo-driver version to v1.4.2. Version v1.0.3 has various vulnerabilities which are highlighted in various code scanners.

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   81.63%   81.63%           
=======================================
  Files          10       10           
  Lines        1285     1285           
=======================================
  Hits         1049     1049           
  Misses        164      164           
  Partials       72       72           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c4c85...2292ffd. Read the comment docs.

@casualjim casualjim merged commit 3236244 into go-openapi:master Oct 28, 2020
@bvwells
Copy link
Contributor Author

bvwells commented Oct 28, 2020

Thanks for the review and merge @casualjim!

@bvwells bvwells deleted the mongo-driver-upgrade branch October 28, 2020 21:50
@bvwells
Copy link
Contributor Author

bvwells commented Oct 29, 2020

@casualjim do you know when you are planning to have the next patch release of this module?

@casualjim
Copy link
Member

done

@bvwells
Copy link
Contributor Author

bvwells commented Oct 29, 2020

Great! Many thanks @casualjim. I can roll this version out across other go-openapi modules if that is okay with you?

@casualjim
Copy link
Member

That's fine although it's not strictly required

@bvwells
Copy link
Contributor Author

bvwells commented Oct 29, 2020

The static analysers I am using analyse the go.sum file so even upgrading our code to the latest go-openapi/strfmt we still have go.sum entries for old versions of this module as the dependency of other go-openapi modules e.g. go-openapi/runtime.

I've noticed that there is a circular dependency between github.com/go-openapi/loads and github.com/go-openapi/analysis. Do you update this in any particular order?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants