empty datetime shouldn't be converted to epoch time #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 89.25% 89.33% +0.08%
==========================================
Files 10 10
Lines 1629 1632 +3
==========================================
+ Hits 1454 1458 +4
+ Misses 146 145 -1
Partials 29 29
Continue to review full report at Codecov.
|
golangcibot
reviewed
Feb 11, 2019
casualjim
approved these changes
Feb 11, 2019
|
the changes look good, but can you address the linter comment? |
fredbi
requested changes
Feb 11, 2019
format.go
Outdated
| return ParseDateTime(data.(string)) | ||
| input := data.(string) | ||
| if len(input) == 0 { | ||
| return nil, fmt.Errorf("empty string it's invalid datetime format") |
There was a problem hiding this comment.
should read "empty string is an invalid datetime format"
…be accepted as valid
* changes error message
* fixes scopelint issue
Signed-off-by: Mario Morgado <[email protected]>
|
a new commit addresses the raised issues. |
casualjim
approved these changes
Feb 11, 2019
fredbi
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #46