Follow up of PR #56 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Return exit status 1 * Refer to README.md * Refer to immediate help via `goenv help init`
|
Tests pass in Travis. Merging and releasing alongside |
honnix
reviewed
Dec 6, 2023
| echo "or run 'goenv help init' for more information" | ||
| exit 1 | ||
| fi | ||
|
|
||
| command_path="$(command -v "goenv-$command" || true)" |
There was a problem hiding this comment.
Sorry for going back to this old issue. I'm a bit confused. Shouldn't here be goenv-sh-$command? I don't see a goenv-shell under libexec, but only goenv-sh-shell.
There was a problem hiding this comment.
Sorry never mind, I did not do eval "$(goenv init -)" properly so goenv did not end up with a shell function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #62 is now merged, #56 is no longer blocked.
I've made some small modifications.
Also added a test for this case.