Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace time.After with Ticker #992

Closed
wants to merge 1 commit into from

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Feb 19, 2025

addresses #423 however as of 1.23 the issue is moot & this was never really leaking since the 1 second would generally pass

this does slightly reduce allocations, but this is on an error path, so not valuably

Implemented as proof of concept, #423 can be closed

@dveeden
Copy link
Collaborator

dveeden commented Feb 19, 2025

Thanks. Interesting. If I understand things correctly this is mostly a FYI and should be closed?

@serprex
Copy link
Contributor Author

serprex commented Feb 19, 2025

@dveeden yes

@serprex serprex closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants