Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: RowsEvent include NextPos(include name) #1007

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: RowsEvent include NextPos(include name) #1007

wants to merge 2 commits into from

Conversation

XUJiahua
Copy link

@XUJiahua XUJiahua commented Mar 5, 2025

Hello,

I need to ensure position persistence when processing each OnRow event. The RowsEvent structure currently stores the position in its header field but doesn't include the binlog name, making the information incomplete.

@dveeden
Copy link
Collaborator

dveeden commented Mar 5, 2025 •
edited
Loading

Could you fix the failing check by running gofumpt on the file?

   Error: canal/rows.go:4:1: File is not properly formatted (gofumpt)
  	"fmt"
  ^

See also: https://github.com/mvdan/gofumpt

@dveeden dveeden added the canal label Mar 5, 2025
@XUJiahua
Copy link
Author

XUJiahua commented Mar 6, 2025

Could you fix the failing check by running gofumpt on the file?

   Error: canal/rows.go:4:1: File is not properly formatted (gofumpt)
  	"fmt"
  ^

See also: https://github.com/mvdan/gofumpt

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
canal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XUJiahua @dveeden