fix bug: context timeout inside for loop, it will case memory leak (#999

)
go-mysql-org · Feb 22, 2025 · c729fe3 · c729fe3
1 parent 14a14f7
commit c729fe3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/replication/backup.go b/replication/backup.go
@@ -69,10 +69,10 @@ func (b *BinlogSyncer) StartBackupWithHandler(p mysql.Position, timeout time.Dur
 		}
 	}()
 
-	for {
-		ctx, cancel := context.WithTimeout(context.Background(), timeout)
-		defer cancel()
+	ctx, cancel := context.WithTimeout(context.Background(), timeout)
+	defer cancel()
 
+	for {
 		select {
 		case <-ctx.Done():
 			return nil