integration FastInvoke Handler #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verify handlers
Update router.go
This commit calls `filepath.EvalSymlinks` before `filepath.Walk` in the initialization of the template file system in order to allow it to be a symlink. Otherwise `filepath.Walk` would just yield the symlink itself, resulting in undefined templates. This does not allow to use symlinks **inside** the template directory. The error handling changes may look odd at first sight but it behaves as before; previously if `opt.Directory` was not an existing file, `filepath.Walk` would call the callback with the same unexisting directory as `path` plus an error (the error being ignored). `filepath.Rel` would not error on this, and the rest of the function would just do nothing provided that the unexisting directory does not have a known extension. Now in case of an error with `filepath.EvalSymlinks`, the rest of the function is just skipped (and as a side effect preventing potential errors when the unexisting directory have a known extension).
…directory-symlink allow symlink as template directory
So other middlewares can use type assertion to check if use has registered real render middleware.
This option allows render to have additional directories to overwrite templates that are previous defined. Also give application ability to have feature like custom templates.
User now allow to set hard limit of cookie.
Print date and time in log for requests.
| @@ -72,6 +72,15 @@ func (r *Request) Body() *RequestBody { | |||
| return &RequestBody{r.Request.Body} | |||
| } | |||
|
|
|||
| // ContextHandler Context Handler | |||
| type ContextHandler func(ctx *Context) | |||
There was a problem hiding this comment.
也许改叫 ContextInvoker 更贴切点？其他地方也是。。
There was a problem hiding this comment.
被 wrap 后这个东西既是 Handler 也是 Invoker, 或者叫 InvokerHandler.
我先改成 Invoker 后面你再看着改吧.
今天的提交把增加的一个 Router.HandlerWrapAction 方法加了点注释, 加了点测试用例. 有了这个方法就不用每个 Handler 显式调用每个 Invoker 包装转换了, 只要 Router 注册的时候写一个统一的 类型断言 包装就行了 .
add Router.HandlerWrapAction test case
unknwon
force-pushed
the
master
branch
2 times, most recently
from
7d0fb8f to
826ddf1
Compare
# Conflicts: # .gitignore # README.md # context.go # context_test.go # logger.go # macaron.go # render.go # render_test.go # return_handler_test.go # router.go # router_test.go # tree_test.go
unknwon
added a commit
that referenced
this pull request
Jan 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
整合
FastInvoke Handler优化, 对Context/Logger/Recovery/render几个中间件做了适配.关联 inject #1 PR .
本次
PR对inject/macaron/sockets几个项目都做了修改和整合.