Skip to content

Question: AMQP transport implementation? #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vetcher opened this issue Mar 16, 2018 · 1 comment
Closed

Question: AMQP transport implementation? #681

vetcher opened this issue Mar 16, 2018 · 1 comment

Comments

@vetcher
Copy link

vetcher commented Mar 16, 2018

Hey, I would like to add amqp transport with an eye on #680 and help of https://github.com/streadway/amqp
Is it OK idea?
@peterbourgon
Copy link
Member

Yes, please take a look at #680 for a similar effort. I would expect to see a transport/amqp.{Client,Server} and roughly equivalent functionality (Before/After funcs, {Decode,Encode}{Request,Response} funcs, etc) to the other transport packages.

@mattfung mattfung mentioned this issue Aug 7, 2018
Merged
mattfung added a commit to cloudpbx/kit that referenced this issue Nov 7, 2018
@mattfung
Add AMQP transport (go-kit#681)
d65c17b 
amqp transport publisher

amqp transport tests

lint fixes for amqp transport

fixed formatting and punctuation

zzz

default ContentType is null, increased max length of correlationId to 255

refractored subscriber EncodeResponseFunc into encode func, and send func

zzz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterbourgon @vetcher