Enable errcheck, Go 1.12 for Travis

errcheck support for modules has been fixed.

.travis.yml

@@ -1,6 +1,7 @@
 language: go
 go:
   - 1.11
+  - 1.12
   - tip
 
 env:
@@ -13,7 +14,7 @@ install:
   - export PATH=$PATH:$GOPATH/bin
 
 script:
-  - make lint coverage
+  - make check coverage
 
 after_success:
   - |

Makefile

@@ -31,13 +31,13 @@ coverage:
 browse-coverage: coverage
 	$(GO) tool cover --html connect.coverprofile
 
+check: lint errcheck
+
 lint:
 	golint --set_exit_status ./...
 
-# Now it needs to be fixed for modules:
-# https://github.com/kisielk/errcheck/issues/155
 errcheck:
-	errcheck --asserts --ignore 'io:Close' $(packages)
+	errcheck --asserts --exclude=err-excludes.txt $(packages)
 
 zen:
 	ginkgo watch -notify $(packages)
@@ -93,5 +93,5 @@ distclean: clean
 	$(GO) clean -i $(packages)
 
 .PHONY: build install test spec coverage browse-coverage
-.PHONY: lint errcheck zen get-devtools
+.PHONY: check lint errcheck zen get-devtools
 .PHONY: dist get-reltools man release

README.md

@@ -178,7 +178,7 @@ $ go test     # etc.
 ```
 
 Note that you _do not_ need to use a workspace, i.e. `$GOPATH`. In fact, you
-should not, or else you'll need to set `GO111MODULE=1` in your shell
+should not, or else you'll need to set `GO111MODULE=on` in your shell
 environment to force module-aware mode on.
 
 Cross-compiling is again standard Go procedure: set `GOOS` and `GOARCH`. For
@@ -206,7 +206,7 @@ files, etc. you'll need to install it using:
 To use the Go library, simply use `go get` and import it in your code as usual:
 
 ```sh
-$ go get -u github.com/go-kafka/connect
+$ go get github.com/go-kafka/connect
 ```
 
 The library has no dependencies beyond the standard library. Dependencies in

err-excludes.txt

@@ -0,0 +1 @@
+(io.ReadCloser).Close